Skip to content

refactor: simplify trace types and helper#1236

Open
BioPhoton wants to merge 23 commits intomainfrom
feat/utils/revamp-trace-types
Open

refactor: simplify trace types and helper#1236
BioPhoton wants to merge 23 commits intomainfrom
feat/utils/revamp-trace-types

Conversation

@BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Feb 3, 2026

Related:

This PR includes:

  • simper tract event types
  • fixed detail structure
  • renamed helper
  • added unique id helper

Followup:

@nx-cloud
Copy link

nx-cloud bot commented Feb 3, 2026

View your CI Pipeline Execution ↗ for commit 50a6580

Command Status Duration Result
nx run ci:code-pushup -- merge-diffs --files=/h... ✅ Succeeded 5s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 1m 32s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 13m 17s View ↗
nx run-many -t unit-test,int-test ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2026-02-08 21:40:06 UTC

@nx-cloud
Copy link

nx-cloud bot commented Feb 3, 2026

View your CI Pipeline Execution ↗ for commit ad83c42

Command Status Duration Result
nx run ci:code-pushup -- merge-diffs --files=/h... ✅ Succeeded 6s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 1m 33s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 13m 39s View ↗
nx run-many -t unit-test,int-test ✅ Succeeded 1m 16s View ↗

☁️ Nx Cloud last updated this comment at 2026-02-03 16:16:42 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 3, 2026

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1236

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1236

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1236

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1236

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1236

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1236

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1236

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1236

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1236

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1236

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1236

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1236

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1236

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1236

commit: 50a6580

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 11b52fe with previous commit 3137af7.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 40 🔴 35 ↓ −4.7
Documentation 🟡 53 🟡 53 ↓ −0.2
Code coverage 🟢 93 🟢 93 ↓ −0.1
Bug prevention 🟡 75 🟡 75 ↓ −0.1
Axe Accessibility 🟡 88 🟡 88 ↓ −0.1
Code style 🟢 100 🟢 100
Security 🔴 47 🔴 47
Updates 🟡 75 🟡 75
Type Safety 🟡 67 🟡 67
Miscellaneous 🟡 67 🟡 67
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟢 92 🟢 92
👎 3 groups regressed, 👍 4 audits improved, 👎 8 audits regressed, 13 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 40 🔴 35 ↓ −4.7
JSDocs coverage Documentation coverage 🟡 53 🟡 53 ↓ −0.2
Code coverage Code coverage metrics 🟢 93 🟢 93 ↓ −0.1

31 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Initial server response time was short 🟥 Root document took 660 ms 🟩 Root document took 460 ms ↓ −29.9 %
Lighthouse Total Blocking Time 🟥 1,040 ms 🟥 2,180 ms ↑ +108.7 %
Lighthouse First Contentful Paint 🟥 3.3 s 🟥 3.0 s ↓ −8 %
JSDocs coverage Types coverage 🟥 264 undocumented types 🟥 264 undocumented types  +0 %
Lighthouse Max Potential First Input Delay 🟥 620 ms 🟥 1,290 ms ↑ +107.7 %
JSDocs coverage Variables coverage 🟥 274 undocumented variables 🟥 273 undocumented variables ↓ −0.4 %
Lighthouse Time to Interactive 🟥 13.1 s 🟥 13.8 s ↑ +5.6 %
Lighthouse Speed Index 🟥 6.8 s 🟥 6.8 s ↓ −0.8 %
JSDocs coverage Functions coverage 🟥 585 undocumented functions 🟥 585 undocumented functions  +0 %
JSDocs coverage Properties coverage 🟥 42 undocumented properties 🟥 43 undocumented properties ↑ +2.4 %
Code coverage Branch coverage 🟨 89.2 % 🟨 89.2 % ↓ −0.1 %
Code coverage Line coverage 🟩 92.8 % 🟩 92.8 % ↓ −0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,089 KiB 🟩 Total size was 2,097 KiB ↑ +0.4 %
Lighthouse Minimizes main-thread work 🟥 8.1 s 🟥 12.2 s ↑ +51 %
Lighthouse JavaScript execution time 🟥 2.1 s 🟥 3.7 s ↑ +77.1 %
Lighthouse Server Backend Latencies 🟩 300 ms 🟩 1,070 ms ↑ +261.3 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +5.6 %
Lighthouse Uses efficient cache policy on static assets 🟨 31 resources found 🟨 31 resources found ↑ +0.1 %
Lighthouse Largest Contentful Paint 🟥 11.7 s 🟥 12.1 s ↑ +4 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 65 KiB 🟥 Potential savings of 80 KiB ↑ +50 %
Lighthouse Network Round Trip Times 🟩 70 ms 🟩 0 ms ↓ −95.3 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 111 KiB 🟥 Potential savings of 111 KiB ↑ +1.7 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 225 KiB 🟥 Potential savings of 225 KiB ↑ +0.8 %
TypeScript Semantic errors 🟥 44 errors 🟥 37 errors ↓ −15.9 %
Lighthouse Cumulative Layout Shift 🟩 0.003 🟩 0 ↓ −100 %

654 other audits are unchanged.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 11b52fe with previous commit 3137af7.

💼 Project utils

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Documentation 🟡 61 🟡 60 ↓ −0.1
Code coverage 🟢 95 🟢 95 ↓ −0.1

4 other categories are unchanged.

👎 2 groups regressed, 👍 1 audit improved, 👎 5 audits regressed

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JSDocs coverage Documentation coverage 🟡 61 🟡 60 ↓ −0.1
Code coverage Code coverage metrics 🟢 95 🟢 95 ↓ −0.1

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
JSDocs coverage Variables coverage 🟥 50 undocumented variables 🟥 49 undocumented variables ↓ −2 %
JSDocs coverage Types coverage 🟨 55 undocumented types 🟨 55 undocumented types  +0 %
JSDocs coverage Functions coverage 🟥 243 undocumented functions 🟥 243 undocumented functions  +0 %
JSDocs coverage Properties coverage 🟥 39 undocumented properties 🟥 40 undocumented properties ↑ +2.6 %
Code coverage Branch coverage 🟩 91.9 % 🟩 91.8 % ↓ −0.1 %
Code coverage Line coverage 🟩 97.8 % 🟩 97.8 % ↓ −0.1 %

438 other audits are unchanged.

💼 Project plugin-lighthouse

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

All of 6 categories are unchanged.

1 audit changed without impacting score

🗃️ Groups

All of 15 groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Branch coverage 🟩 98.8 % 🟩 98.8 % ↑ +0.1 %

443 other audits are unchanged.


12 other projects are unchanged.

@BioPhoton BioPhoton marked this pull request as ready for review February 3, 2026 16:18
@BioPhoton BioPhoton requested a review from hanna-skryl February 3, 2026 21:47
@BioPhoton BioPhoton enabled auto-merge (squash) February 3, 2026 22:11
@BioPhoton BioPhoton requested a review from hanna-skryl February 8, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants